Comments on: How To Make Your Team’s Code Better http://www.brandonsavage.net/how-to-make-your-teams-code-better/?utm_source=rss&utm_medium=rss&utm_campaign=how-to-make-your-teams-code-better The personal blog of Brandon Savage. Contains entries of a personal and professional nature focusing on PHP, Apple, LAMP, MySQL and Washington, DC. Wed, 15 May 2013 14:54:51 +0000 hourly 1 http://wordpress.org/?v=3.5.2-alpha By: Mute http://www.brandonsavage.net/how-to-make-your-teams-code-better/#comment-7085 Mute Sun, 03 Feb 2013 10:02:42 +0000 http://www.brandonsavage.net/?p=2057#comment-7085 We have been using phabricator (http://phabricator.org) and its really really good. The arcanist workflow and cli tool makes working and reviewing much easier, for us it worked better than github.

If anyone is considering making code reviews the cornerstone of their development process I would highly suggest they give it a try.

A basic example of the workflow would be:

git checkout -tb private/mychange
…do changes
git commit -am”blah”
arc diff (creates a review request)
… wait for review, when its accepted
arc land –squash (apply the change to master and squash the commits)

]]> By: Thomas Ploch http://www.brandonsavage.net/how-to-make-your-teams-code-better/#comment-6883 Thomas Ploch Fri, 25 Jan 2013 06:54:40 +0000 http://www.brandonsavage.net/?p=2057#comment-6883 I hav introduced the GitHub PR workflow with bi-weekly review of critical patches. The best thing that you forgot is that you can trigger automatic builds for PR commits on your company’s CI Server.

]]> By: Brandon Savage http://www.brandonsavage.net/how-to-make-your-teams-code-better/#comment-6876 Brandon Savage Thu, 24 Jan 2013 19:36:54 +0000 http://www.brandonsavage.net/?p=2057#comment-6876 Nits are small problems in the code. Typically nits can be resolved without a second review. For example, if you’re writing Javascript and are inconsistent about semicolon use, the reviewer might tell you to make that consistent and approve it “with nits” meaning “with small changes that don’t need a second review.”

]]> By: cordoval http://www.brandonsavage.net/how-to-make-your-teams-code-better/#comment-6875 cordoval Thu, 24 Jan 2013 19:35:24 +0000 http://www.brandonsavage.net/?p=2057#comment-6875 what is nits?

]]>