Comments on: Peer Review: Looking At Abstraction – Redux http://www.brandonsavage.net/peer-review-looking-at-abstraction-redux/ The personal blog of Brandon Savage. Contains entries of a personal and professional nature focusing on PHP, Apple, LAMP, MySQL and Washington, DC. Thu, 29 Jul 2010 11:09:38 +0000 hourly 1 http://wordpress.org/?v=3.0 By: Brandon Savage http://www.brandonsavage.net/peer-review-looking-at-abstraction-redux/#comment-1056 Brandon Savage Mon, 31 Aug 2009 21:56:15 +0000 http://www.brandonsavage.net/?p=590#comment-1056 That's certainly a valid option as well. In fact, Propel offers the ability to customize some of the functions in the data model, which is where I might put some of this logic. That’s certainly a valid option as well. In fact, Propel offers the ability to customize some of the functions in the data model, which is where I might put some of this logic.

]]> By: David http://www.brandonsavage.net/peer-review-looking-at-abstraction-redux/#comment-1054 David Mon, 31 Aug 2009 14:35:23 +0000 http://www.brandonsavage.net/?p=590#comment-1054 What about setting up a storage adapter? (not sure if that's the right pattern name...) But basically, something like: $twitter = new Twitter; $twitter->setStorage(new Twitter_Storage_Propel()); .... protected function already_tweeted($message){ $hash = md5( date('Y-m-d') . $message); $storage = $this->getStorage(); if($storage->messageExists($message)){ return true; } try{ $storage->save($message, $hash); }catch($e Exception){ throw new Exception('There was an error in saving the item.'); } return false; } Yes, it adds even another layer of abstraction, but that way the Twitter class doesn't have to know anything about how to save the message, and instead passes that on to the storage class. What about setting up a storage adapter? (not sure if that’s the right pattern name…)

But basically, something like:

$twitter = new Twitter;
$twitter->setStorage(new Twitter_Storage_Propel());
….
protected function already_tweeted($message){

$hash = md5( date(‘Y-m-d’) . $message);

$storage = $this->getStorage();

if($storage->messageExists($message)){
return true;
}
try{
$storage->save($message, $hash);
}catch($e Exception){
throw new Exception(‘There was an error in saving the item.’);
}
return false;
}

Yes, it adds even another layer of abstraction, but that way the Twitter class doesn’t have to know anything about how to save the message, and instead passes that on to the storage class.

]]>